changeset 1961:ef0e05668f39

HTTP: adding a warning for ignored outgoing header assignments.
author Dmitry Volyntsev <xeioex@nginx.com>
date Thu, 22 Sep 2022 19:05:36 -0700
parents 74d30c2d70f3
children 7a4f1f8a2cae
files nginx/ngx_http_js_module.c
diffstat 1 files changed, 5 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/nginx/ngx_http_js_module.c	Tue Sep 20 17:44:25 2022 -0700
+++ b/nginx/ngx_http_js_module.c	Thu Sep 22 19:05:36 2022 -0700
@@ -1565,6 +1565,11 @@
         return NJS_DECLINED;
     }
 
+    if (r->header_sent && setval != NULL) {
+        njs_vm_warn(vm, "ignored setting of response header \"%V\" because"
+                        " headers were already sent", &name);
+    }
+
     for (h = headers_out; h->name.length > 0; h++) {
         if (h->name.length == name.length
             && ngx_strncasecmp(h->name.start, name.start, name.length) == 0)